-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top-level code environment updates #3
Open
soltanoff
wants to merge
8
commits into
venthur:master
Choose a base branch
from
soltanoff:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@venthur, hi! Thank you! |
Hi, thank you very much for the PR! Can you please separate the wxpython specific changes from the other ones? I.e. there are a lot of unrelated changes in this PR, which should go into separate ones so I can review and merge them individually. Thank you! |
soltanoff
changed the title
wxPython 4.2.0 compatibility
Top-level code environment updates
Feb 6, 2023
Hi, sure! PR is ready: #4 Thank you! |
I’ll rebase it soon. Thank you, @venthur! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wxPython 4.2.0 compatibility(wxPython packages updates: v4.2.0 #4)Fixed deprecation warning(wxPython packages updates: v4.2.0 #4)setup.py
: updated and fixed installation metaversion
control: renameversion.py
->vertion.txt
requirements.txt
.flake8
and fixed the code.editorconfig